Skip to content

Analytics Hub: Adds a placeholder for images #8411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2022
Merged

Analytics Hub: Adds a placeholder for images #8411

merged 1 commit into from
Dec 15, 2022

Conversation

@Ecarrion
Copy link
Contributor

@Ecarrion Ecarrion commented Dec 14, 2022

Closes: #8404

Why

This PR adds a placeholder image to be shown while the images from the top items sold list is are loading.

Screenshots

Testing Steps

  • Go to the analytics Hub
  • Select a range that has product with images that hasn't been load into memory before
  • See the placeholder while the image loads.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Ecarrion Ecarrion added the category: tracks Related to analytics, including Tracks Events. label Dec 14, 2022
@Ecarrion Ecarrion added this to the 11.7 milestone Dec 14, 2022
@peril-woocommerce
Copy link

peril-woocommerce bot commented Dec 14, 2022

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 14, 2022

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8411-e816262 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@Ecarrion Ecarrion mentioned this pull request Dec 14, 2022
Merged
1 task
@ThomazFB ThomazFB self-assigned this Dec 14, 2022
ThomazFB
ThomazFB approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@ThomazFB ThomazFB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looking good here from my end! Thanks!

Before After
Simulator Screen Shot - iPhone 14 Pro - 2022-12-14 at 20 24 39 Simulator Screen Shot - iPhone 14 Pro - 2022-12-14 at 20 25 36

@Ecarrion Ecarrion merged commit dfb2881 into trunk Dec 15, 2022
@Ecarrion Ecarrion deleted the issue/8404-placeholder-products branch December 15, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ealeksandrov ealeksandrov Awaiting requested review from ealeksandrov

@rachelmcr rachelmcr Awaiting requested review from rachelmcr

1 more reviewer

@ThomazFB ThomazFB ThomazFB approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ThomazFB ThomazFB

Labels

category: tracks Related to analytics, including Tracks Events.

Projects

None yet

Milestone

11.7

Development

Successfully merging this pull request may close these issues.

Placeholder for products without images are missing on the analitics screen

4 participants

@Ecarrion @wpmobilebot @ThomazFB